linux-kernel - Re: [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b1960f2-95e4-41c3-9723-04d77c6c27d4@kernel.org>
Date: Fri, 23 May 2025 08:24:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-wireless@...r.kernel.org, Toke Høiland-Jørgensen <toke@...e.dk>, Johannes Berg <johannes@...solutions.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 "open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings

On 23/05/2025 02:04, Rosen Penev wrote:
> On Thu, May 22, 2025 at 12:54 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 22/05/2025 20:45, Rosen Penev wrote:
>>> Now that support was added to the driver, document it.
>>
>> That's not appropriate commit msg. Binding must be before the user (see
>> submitting patches in DT directory). Describe the hardware, what are you
>> adding here.
>>
>> Subject: OF bindings is redundant. It duplicates dt-bindings. Instead:
>> "Add Atheros AR9-foo-bar on AHB bus" or something similar
> At this point I wonder if my approach is wrong. The other ath drivers
> use a qcom, prefix and a -wifi suffix. Might make sense to do the same
> here to avoid typing qca twice.



Yes, probably this should be qcom.


Best regards,
Krzysztof