linux-kernel - Re: [PATCH] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDAvnmtgnssj7K5l@stanley.mountain>
Date: Fri, 23 May 2025 11:19:42 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: rujra <braker.noob.kernel@...il.com>
Cc: Johan Hovold <johan@...nel.org>, elder@...nel.org,
	Greg KH <gregkh@...uxfoundation.org>, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging : greybus : Documentation : firmware : Replace
 deprecated strncpy() with strscpy()

On Sat, May 17, 2025 at 09:11:30AM +0530, rujra wrote:
> To ensuring that the firmware_tag is properly null-terminated. When
> copying firmware tag strings to prevent buffer overflows and ensure
> data integrity.
> 
> The maximum size of tag is GB_FIRMWARE_U_TAG_MAX_SIZE = 10 bytes, and it
> may or may not be NULL-terminated.
> included in "greybus_firmware.h"
> 
> changes has been made at 3 positions:
> 1: update firmware tag
> 2: backend update firmware tag
> 3: backend update firmware tag with unipro
> 
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@...il.com>

>From doesn't match Signed-off-by line.

The patch is corrupted and doesn't apply.  Read the two paragraphs of
Documentation/process/email-clients.rst.

This is a usespace program so I don't think it has a strscpy()
function.  How did you compile this?

regards,
dan carpenter