linux-kernel - Re: [PATCH] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG+54DZC9ATaTme_WknauN5LVQRKut-ZJs8SAaZv8FbcQMCf7Q@mail.gmail.com>
Date: Sun, 1 Jun 2025 15:01:07 +0530
From: Rujra Bhatt <braker.noob.kernel@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Johan Hovold <johan@...nel.org>, elder@...nel.org, 
	Greg KH <gregkh@...uxfoundation.org>, greybus-dev@...ts.linaro.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging : greybus : Documentation : firmware : Replace
 deprecated strncpy() with strscpy()

Hi Dan,



On Fri, May 23, 2025 at 1:49 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> On Sat, May 17, 2025 at 09:11:30AM +0530, rujra wrote:
> > To ensuring that the firmware_tag is properly null-terminated. When
> > copying firmware tag strings to prevent buffer overflows and ensure
> > data integrity.
> >
> > The maximum size of tag is GB_FIRMWARE_U_TAG_MAX_SIZE = 10 bytes, and it
> > may or may not be NULL-terminated.
> > included in "greybus_firmware.h"
> >
> > changes has been made at 3 positions:
> > 1: update firmware tag
> > 2: backend update firmware tag
> > 3: backend update firmware tag with unipro
> >
> > Signed-off-by: Rujra Bhatt <braker.noob.kernel@...il.com>
>
> From doesn't match Signed-off-by line.
>
> The patch is corrupted and doesn't apply.  Read the two paragraphs of
> Documentation/process/email-clients.rst.
>
> This is a usespace program so I don't think it has a strscpy()
> function.  How did you compile this?

I mistakenly submitted the patch with a mismatched From: and
Signed-off-by: line. I’ll correct the author information from now
onwards patches by following the guidance in
Documentation/process/email-clients.rst.

Also, regarding the use of strscpy():
You're absolutely correct. It's a kernel-space function and not
available in user space. That call shouldn’t have been there. I’ll
replace it with a suitable userspace alternative, such as strncpy(),
as earlier it was.

Also I am not able to compile it properly. Will learn it the proper
way, as I have tried to compile it via turning ON the kernel
menuconfig for greybus support and
--- [*]"Greybus Firmware Download Class driver" then compiled it using
make and installed it, Also have not tested via "gcc -o firmware
firmware.c".
If you have any suggestions on how to compile or test this more
effectively, I would really appreciate your guidance.

Thank you so much for the feedback and review. Also sorry for my
delayed response.

regards,
Rujra Bhatt