linux-kernel - Re: [PATCH v2 07/14] s390: Handle KCOV _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250523093548.9524A8b-hca@linux.ibm.com>
Date: Fri, 23 May 2025 11:35:48 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Kees Cook <kees@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Gaosheng Cui <cuigaosheng1@...wei.com>, linux-s390@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Christoph Hellwig <hch@....de>, Marco Elver <elver@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nicolas Schier <nicolas.schier@...ux.dev>,
        Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
        Bill Wendling <morbo@...gle.com>,
        Justin Stitt <justinstitt@...gle.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, kasan-dev@...glegroups.com, linux-doc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
        linux-riscv@...ts.infradead.org, linux-efi@...r.kernel.org,
        linux-hardening@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kselftest@...r.kernel.org,
        sparclinux@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 07/14] s390: Handle KCOV __init vs inline mismatches

On Thu, May 22, 2025 at 09:39:17PM -0700, Kees Cook wrote:
> When KCOV is enabled all functions get instrumented, unless
> the __no_sanitize_coverage attribute is used. To prepare for
> __no_sanitize_coverage being applied to __init functions, we have to
> handle differences in how GCC's inline optimizations get resolved. For
> s390 this exposed a place where the __init annotation was missing but
> ended up being "accidentally correct". Fix this cases and force a couple
> functions to be inline with __always_inline.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: Gerald Schaefer <gerald.schaefer@...ux.ibm.com>
> Cc: Gaosheng Cui <cuigaosheng1@...wei.com>
> Cc: <linux-s390@...r.kernel.org>
> ---
>  arch/s390/hypfs/hypfs.h      | 2 +-
>  arch/s390/hypfs/hypfs_diag.h | 2 +-
>  arch/s390/mm/init.c          | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Heiko Carstens <hca@...ux.ibm.com>