linux-kernel - Re: [PATCH 1/8] dt-bindings: clock: Document Loongson 2K0300 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5a09a55-844b-4045-9459-e61abda255f3@kernel.org>
Date: Fri, 23 May 2025 13:37:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yao Zi <ziyao@...root.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
 WANG Xuerui <kernel@...0n.name>, Yinbo Zhu <zhuyinbo@...ngson.cn>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 Mingcong Bai <jeffbai@...c.io>, Kexy Biscuit <kexybiscuit@...c.io>
Subject: Re: [PATCH 1/8] dt-bindings: clock: Document Loongson 2K0300 clock
 controller

On 23/05/2025 12:45, Yao Zi wrote:
> +maintainers:
> +  - Yao Zi <ziyao@...root.org>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Loongson 2K0300 clock controller generates various clocks for SoC
> +  peripherals. See include/dt-bindings/clock/loongson,ls2k0300-clk.h for
> +  valid clock IDs.
> +
> +properties:
> +  compatible:
> +    const: loongson,ls2k0300-clk
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: External 120MHz reference clock
> +
> +  clock-names:
> +    items:
> +      - const: ref_120m

Just ref or drop the clock-names completely.

> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clk: clock-controller@...00400 {

Drop unused label

> +        compatible = "loongson,ls2k0300-clk";
> +        reg = <0x16000400 0x100>;
> +        clocks = <&ref_120m>;
> +        clock-names = "ref_120m";
> +        #clock-cells = <1>;

With above changes:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof