| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250524173745.4907-1-donnyturizo13@gmail.com>
Date: Sat, 24 May 2025 17:37:45 +0000
From: Donny Turizo <donnyturizo13@...il.com>
To: gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Donny Turizo <donnyturizo13@...il.com>
Subject: [PATCH v6] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake_case
Renamed _Read_EEPROM and several other functions in rtw_cmd.c to follow
the kernel coding style (snake_case). This fixes checkpatch warnings
related to naming conventions.
Signed-off-by: Donny Turizo <donnyturizo13@...il.com>
---
v2: Initial patch rejected by the robot due to naming issues.
v3: Rebased the patch onto GregKH's staging branch for better integration.
v4: Changed the commit author to my name and renamed all remaining functions
to snake_case following kernel coding style.
v5: Renamed command _set_h2c_Lbk to _set_h2c_lbk to fix CamelCase issue.
v6: Actually fixed the misspelled name that was incorrectly stated as
fixed in v5.
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 140 +++++++++---------
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
.../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
3 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 49bcefb5e8d2..a73c83f804e4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -11,76 +11,76 @@
static struct _cmd_callback rtw_cmd_callback[] = {
{GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
{GEN_CMD_CODE(_write_macreg), NULL},
- {GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
- {GEN_CMD_CODE(_Write_BBREG), NULL},
- {GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
- {GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
- {GEN_CMD_CODE(_Read_EEPROM), NULL},
- {GEN_CMD_CODE(_Write_EEPROM), NULL},
- {GEN_CMD_CODE(_Read_EFUSE), NULL},
- {GEN_CMD_CODE(_Write_EFUSE), NULL},
-
- {GEN_CMD_CODE(_Read_CAM), NULL}, /*10*/
- {GEN_CMD_CODE(_Write_CAM), NULL},
- {GEN_CMD_CODE(_setBCNITV), NULL},
- {GEN_CMD_CODE(_setMBIDCFG), NULL},
- {GEN_CMD_CODE(_JoinBss), &rtw_joinbss_cmd_callback}, /*14*/
- {GEN_CMD_CODE(_DisConnect), &rtw_disassoc_cmd_callback}, /*15*/
- {GEN_CMD_CODE(_CreateBss), &rtw_createbss_cmd_callback},
- {GEN_CMD_CODE(_SetOpMode), NULL},
- {GEN_CMD_CODE(_SiteSurvey), &rtw_survey_cmd_callback}, /*18*/
- {GEN_CMD_CODE(_SetAuth), NULL},
-
- {GEN_CMD_CODE(_SetKey), NULL}, /*20*/
- {GEN_CMD_CODE(_SetStaKey), &rtw_setstaKey_cmdrsp_callback},
- {GEN_CMD_CODE(_SetAssocSta), &rtw_setassocsta_cmdrsp_callback},
- {GEN_CMD_CODE(_DelAssocSta), NULL},
- {GEN_CMD_CODE(_SetStaPwrState), NULL},
- {GEN_CMD_CODE(_SetBasicRate), NULL}, /*25*/
- {GEN_CMD_CODE(_GetBasicRate), NULL},
- {GEN_CMD_CODE(_SetDataRate), NULL},
- {GEN_CMD_CODE(_GetDataRate), NULL},
- {GEN_CMD_CODE(_SetPhyInfo), NULL},
-
- {GEN_CMD_CODE(_GetPhyInfo), NULL}, /*30*/
- {GEN_CMD_CODE(_SetPhy), NULL},
- {GEN_CMD_CODE(_GetPhy), NULL},
- {GEN_CMD_CODE(_readRssi), NULL},
- {GEN_CMD_CODE(_readGain), NULL},
- {GEN_CMD_CODE(_SetAtim), NULL}, /*35*/
- {GEN_CMD_CODE(_SetPwrMode), NULL},
- {GEN_CMD_CODE(_JoinbssRpt), NULL},
- {GEN_CMD_CODE(_SetRaTable), NULL},
- {GEN_CMD_CODE(_GetRaTable), NULL},
-
- {GEN_CMD_CODE(_GetCCXReport), NULL}, /*40*/
- {GEN_CMD_CODE(_GetDTMReport), NULL},
- {GEN_CMD_CODE(_GetTXRateStatistics), NULL},
- {GEN_CMD_CODE(_SetUsbSuspend), NULL},
- {GEN_CMD_CODE(_SetH2cLbk), NULL},
- {GEN_CMD_CODE(_AddBAReq), NULL}, /*45*/
- {GEN_CMD_CODE(_SetChannel), NULL}, /*46*/
- {GEN_CMD_CODE(_SetTxPower), NULL},
- {GEN_CMD_CODE(_SwitchAntenna), NULL},
- {GEN_CMD_CODE(_SetCrystalCap), NULL},
- {GEN_CMD_CODE(_SetSingleCarrierTx), NULL}, /*50*/
-
- {GEN_CMD_CODE(_SetSingleToneTx), NULL}, /*51*/
- {GEN_CMD_CODE(_SetCarrierSuppressionTx), NULL},
- {GEN_CMD_CODE(_SetContinuousTx), NULL},
- {GEN_CMD_CODE(_SwitchBandwidth), NULL}, /*54*/
- {GEN_CMD_CODE(_TX_Beacon), NULL},/*55*/
-
- {GEN_CMD_CODE(_Set_MLME_EVT), NULL},/*56*/
- {GEN_CMD_CODE(_Set_Drv_Extra), NULL},/*57*/
- {GEN_CMD_CODE(_Set_H2C_MSG), NULL},/*58*/
- {GEN_CMD_CODE(_SetChannelPlan), NULL},/*59*/
-
- {GEN_CMD_CODE(_SetChannelSwitch), NULL},/*60*/
- {GEN_CMD_CODE(_TDLS), NULL},/*61*/
- {GEN_CMD_CODE(_ChkBMCSleepq), NULL}, /*62*/
-
- {GEN_CMD_CODE(_RunInThreadCMD), NULL},/*63*/
+ {GEN_CMD_CODE(_read_bbreg), &rtw_getbbrfreg_cmdrsp_callback},
+ {GEN_CMD_CODE(_write_bbreg), NULL},
+ {GEN_CMD_CODE(_read_rfreg), &rtw_getbbrfreg_cmdrsp_callback},
+ {GEN_CMD_CODE(_write_rfreg), NULL}, /*5*/
+ {GEN_CMD_CODE(_read_eeprom), NULL},
+ {GEN_CMD_CODE(_write_eeprom), NULL},
+ {GEN_CMD_CODE(_read_efuse), NULL},
+ {GEN_CMD_CODE(_write_efuse), NULL},
+
+ {GEN_CMD_CODE(_read_cam), NULL}, /*10*/
+ {GEN_CMD_CODE(_write_cam), NULL},
+ {GEN_CMD_CODE(_set_bcnitv), NULL},
+ {GEN_CMD_CODE(_set_mbidcfg), NULL},
+ {GEN_CMD_CODE(_join_bss), &rtw_joinbss_cmd_callback}, /*14*/
+ {GEN_CMD_CODE(_disconnect), &rtw_disassoc_cmd_callback}, /*15*/
+ {GEN_CMD_CODE(_create_bss), &rtw_createbss_cmd_callback},
+ {GEN_CMD_CODE(_set_op_mode), NULL},
+ {GEN_CMD_CODE(_site_survey), &rtw_survey_cmd_callback}, /*18*/
+ {GEN_CMD_CODE(_set_auth), NULL},
+
+ {GEN_CMD_CODE(_set_key), NULL}, /*20*/
+ {GEN_CMD_CODE(_set_sta_key), &rtw_setstaKey_cmdrsp_callback},
+ {GEN_CMD_CODE(_set_assoc_sta), &rtw_setassocsta_cmdrsp_callback},
+ {GEN_CMD_CODE(_del_assoc_sta), NULL},
+ {GEN_CMD_CODE(_set_sta_pwr_state), NULL},
+ {GEN_CMD_CODE(_set_basic_rate), NULL}, /*25*/
+ {GEN_CMD_CODE(_get_basic_rate), NULL},
+ {GEN_CMD_CODE(_set_data_rate), NULL},
+ {GEN_CMD_CODE(_get_data_rate), NULL},
+ {GEN_CMD_CODE(_set_phy_info), NULL},
+
+ {GEN_CMD_CODE(_get_phy_info), NULL}, /*30*/
+ {GEN_CMD_CODE(_set_phy), NULL},
+ {GEN_CMD_CODE(_get_phy), NULL},
+ {GEN_CMD_CODE(_read_rssi), NULL},
+ {GEN_CMD_CODE(_read_gain), NULL},
+ {GEN_CMD_CODE(_set_atim), NULL}, /*35*/
+ {GEN_CMD_CODE(_set_pwr_mode), NULL},
+ {GEN_CMD_CODE(_joinbss_rpt), NULL},
+ {GEN_CMD_CODE(_set_ra_table), NULL},
+ {GEN_CMD_CODE(_get_ra_table), NULL},
+
+ {GEN_CMD_CODE(_get_ccx_report), NULL}, /*40*/
+ {GEN_CMD_CODE(_get_dtm_report), NULL},
+ {GEN_CMD_CODE(_get_tx_rate_statistics), NULL},
+ {GEN_CMD_CODE(_set_usb_suspend), NULL},
+ {GEN_CMD_CODE(_set_h2c_lbk), NULL},
+ {GEN_CMD_CODE(_add_ba_req), NULL}, /*45*/
+ {GEN_CMD_CODE(_set_channel), NULL}, /*46*/
+ {GEN_CMD_CODE(_set_tx_power), NULL},
+ {GEN_CMD_CODE(_switch_antenna), NULL},
+ {GEN_CMD_CODE(_set_crystal_cap), NULL},
+ {GEN_CMD_CODE(_set_single_carrier_tx), NULL}, /*50*/
+
+ {GEN_CMD_CODE(_set_single_tone_tx), NULL}, /*51*/
+ {GEN_CMD_CODE(_set_carrier_suppression_tx), NULL},
+ {GEN_CMD_CODE(_set_continuous_tx), NULL},
+ {GEN_CMD_CODE(_switch_bandwidth), NULL}, /*54*/
+ {GEN_CMD_CODE(_tx_beacon), NULL},/*55*/
+
+ {GEN_CMD_CODE(_set_mlme_evt), NULL},/*56*/
+ {GEN_CMD_CODE(_set_drv_extra), NULL},/*57*/
+ {GEN_CMD_CODE(_set_h2c_msg), NULL},/*58*/
+ {GEN_CMD_CODE(_set_channel_plan), NULL},/*59*/
+
+ {GEN_CMD_CODE(_set_channel_switch), NULL},/*60*/
+ {GEN_CMD_CODE(_tdls), NULL},/*61*/
+ {GEN_CMD_CODE(_chk_bmc_sleepq), NULL}, /*62*/
+
+ {GEN_CMD_CODE(_run_in_thread_cmd), NULL},/*63*/
};
static struct cmd_hdl wlancmds[] = {
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index cb44119ce9a9..e4e7e350d0fc 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -636,7 +636,7 @@ enum {
GEN_CMD_CODE(_Write_BBREG),
GEN_CMD_CODE(_Read_RFREG),
GEN_CMD_CODE(_Write_RFREG), /*5*/
- GEN_CMD_CODE(_Read_EEPROM),
+ GEN_CMD_CODE(_read_eeprom),
GEN_CMD_CODE(_Write_EEPROM),
GEN_CMD_CODE(_Read_EFUSE),
GEN_CMD_CODE(_Write_EFUSE),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 2080408743ef..63373d665d4f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -684,7 +684,7 @@ enum {
GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
GEN_EVT_CODE(_Read_BBREG),
GEN_EVT_CODE(_Read_RFREG),
- GEN_EVT_CODE(_Read_EEPROM),
+ GEN_EVT_CODE(_read_eeprom),
GEN_EVT_CODE(_Read_EFUSE),
GEN_EVT_CODE(_Read_CAM), /*5*/
GEN_EVT_CODE(_Get_BasicRate),
--
2.43.0
Powered by blists - more mailing lists