linux-kernel - Re: [PATCH v6] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDQgQw9XZV_7BIf-@stanley.mountain>
Date: Mon, 26 May 2025 11:03:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Donny Turizo <donnyturizo13@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] staging: rtl8723bs: rename _Read_EEPROM and other
 functions to snake_case

On Sat, May 24, 2025 at 05:37:45PM +0000, Donny Turizo wrote:
> Renamed _Read_EEPROM and several other functions in rtw_cmd.c to follow
> the kernel coding style (snake_case). This fixes checkpatch warnings
> related to naming conventions.
> 
> Signed-off-by: Donny Turizo <donnyturizo13@...il.com>
> 
> ---
> v2: Initial patch rejected by the robot due to naming issues.
> 
> v3: Rebased the patch onto GregKH's staging branch for better integration.
> 
> v4: Changed the commit author to my name and renamed all remaining functions
>     to snake_case following kernel coding style.
> 
> v5: Renamed command _set_h2c_Lbk to _set_h2c_lbk to fix CamelCase issue.
> 
> v6: Actually fixed the misspelled name that was incorrectly stated as
>   fixed in v5.

Surely, this breaks the build?  You're not working against staging-next
so it's difficult for me to apply this and actually check.

regards,
dan carpenter