linux-kernel - Re: [PATCH v2 3/3] platform/x86: dell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b975c429-25e9-3cff-8d43-d2b40f8fb9bd@linux.intel.com>
Date: Mon, 26 May 2025 01:14:06 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Stuart Hayes <stuart.w.hayes@...il.com>
cc: LKML <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, 
    platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data
 buffer

On Thu, 22 May 2025, Stuart Hayes wrote:

> The dell_rbu driver will use memset to clear the data held by each packet

Please add () after function names.

> when it is no longer needed (when the driver is unloaded, the packet size
> is changed, etc).
> 
> The amount of memory that is cleared is (currently) the normal packet
> size.  However, the last packet in the list may be smaller.  Fix this to

One space is enough after .

> only clear the memory actually used by each packet, to prevent it from
> writing past the end of data buffer.
> 
> Signed-off-by: Stuart Hayes <stuart.w.hayes@...il.com>

Fixes tag?

> ---
>  drivers/platform/x86/dell/dell_rbu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/dell/dell_rbu.c
> index c03d4d55fcc1..7d5b26735a20 100644
> --- a/drivers/platform/x86/dell/dell_rbu.c
> +++ b/drivers/platform/x86/dell/dell_rbu.c
> @@ -322,7 +322,7 @@ static void packet_empty_list(void)
>  		 * zero out the RBU packet memory before freeing
>  		 * to make sure there are no stale RBU packets left in memory
>  		 */
> -		memset(newpacket->data, 0, rbu_data.packetsize);
> +		memset(newpacket->data, 0, newpacket->length);
>  		set_memory_wb((unsigned long)newpacket->data,
>  			1 << newpacket->ordernum);
>  		free_pages((unsigned long) newpacket->data,
> 

-- 
 i.