linux-kernel - Re: [PATCH v2 3/3] platform/x86: dell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a1a1d6e-4d0b-4c0a-aa5c-31ee9ad65da2@gmail.com>
Date: Thu, 29 May 2025 17:12:29 -0500
From: stuart hayes <stuart.w.hayes@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>,
 platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data
 buffer

On 5/25/2025 5:14 PM, Ilpo Järvinen wrote:
> On Thu, 22 May 2025, Stuart Hayes wrote:
> 
>> The dell_rbu driver will use memset to clear the data held by each packet
> 
> Please add () after function names.
> 
>> when it is no longer needed (when the driver is unloaded, the packet size
>> is changed, etc).
>>
>> The amount of memory that is cleared is (currently) the normal packet
>> size.  However, the last packet in the list may be smaller.  Fix this to
> 
> One space is enough after .
> 
>> only clear the memory actually used by each packet, to prevent it from
>> writing past the end of data buffer.
>>
>> Signed-off-by: Stuart Hayes <stuart.w.hayes@...il.com>
> 
> Fixes tag?
> 
>> ---

Thank you for reviewing this! I sent a new version (V3) with these fixes 
(and a module version bump).