linux-kernel - Re: [PATCH v4 3/6] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fb2756ce0e34be56df40187370a28d7a2a3f321.camel@gmail.com>
Date: Mon, 26 May 2025 10:53:43 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Pop Ioan Daniel	
 <pop.ioan-daniel@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron
 <jic23@...nel.org>, Nuno Sá	 <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Rob Herring	 <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley	 <conor+dt@...nel.org>, Sergiu
 Cuciurean <sergiu.cuciurean@...log.com>,  Dragos Bogdan
 <dragos.bogdan@...log.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Olivier Moysan	 <olivier.moysan@...s.st.com>, Javier Carrasco
 <javier.carrasco.cruz@...il.com>,  Matti Vaittinen
 <mazziesaccount@...il.com>, Tobias Sperling <tobias.sperling@...ting.com>,
 Alisa-Dariana Roman	 <alisadariana@...il.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>,  João Paulo
 Gonçalves	 <joao.goncalves@...adex.com>, Thomas
 Bonnefille <thomas.bonnefille@...tlin.com>, 	linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/6] iio: adc: adi-axi-adc: add
 axi_adc_oversampling_ratio_set

On Mon, 2025-05-19 at 10:15 -0500, David Lechner wrote:
> On 5/19/25 9:02 AM, Pop Ioan Daniel wrote:
> > Add support for setting decimation rate.
> > 
> > Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> > ---
> 
> With the bit below fixed:
> 
> Reviewed-by: David Lechner <dlechner@...libre.com>
> 
> ...
> > @@ -381,7 +397,8 @@ static int axi_adc_ad485x_data_size_set(struct
> > iio_backend *back,
> >  }
> >  
> >  static int axi_adc_ad485x_oversampling_ratio_set(struct iio_backend *back,
> > -					  unsigned int ratio)
> > +						 unsigned int chan,
> > +						 unsigned int ratio)
> 
> I think this change belongs in the previous patch. Most importantly because
> it could cause a compile error during a git bisect, but also because that
> is where it logically belongs.

I was wondering about this. Definitely needs to be in the previous one...

> 
> >  {
> >  	struct adi_axi_adc_state *st = iio_backend_get_priv(back);
> >