linux-kernel - Re: [PATCH v4 2/6] iio: backend: update iio_backend_oversampling_ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90194d4e3c48de7b3b4948aeb536708a4bed2354.camel@gmail.com>
Date: Mon, 26 May 2025 10:54:35 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>, Lars-Peter Clausen	
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
 Jonathan Cameron	 <jic23@...nel.org>, David Lechner
 <dlechner@...libre.com>, Nuno Sá	 <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring	 <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley	
 <conor+dt@...nel.org>, Sergiu Cuciurean <sergiu.cuciurean@...log.com>, 
 Dragos Bogdan <dragos.bogdan@...log.com>, Antoniu Miclaus
 <antoniu.miclaus@...log.com>, Olivier Moysan	 <olivier.moysan@...s.st.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,  Matti Vaittinen
 <mazziesaccount@...il.com>, Tobias Sperling <tobias.sperling@...ting.com>,
 Alisa-Dariana Roman	 <alisadariana@...il.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>,  Herve Codina <herve.codina@...tlin.com>,
 Trevor Gamblin <tgamblin@...libre.com>, Thomas Bonnefille	
 <thomas.bonnefille@...tlin.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/6] iio: backend: update
 iio_backend_oversampling_ratio_set

On Mon, 2025-05-19 at 17:02 +0300, Pop Ioan Daniel wrote:
> Add chan parameter to iio_backed_oversampling_ration_set() to allow
> for contexts where the channel must be specified. Modify all
> existing users.
> 
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
> ---

With the change requested by David in the following patch:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

> changes in v4:
>  - pass 0 in the list of parameters instead of chan
>  drivers/iio/adc/ad4851.c           | 4 ++--
>  drivers/iio/industrialio-backend.c | 3 ++-
>  include/linux/iio/backend.h        | 3 ++-
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad4851.c b/drivers/iio/adc/ad4851.c
> index 12f90aa3a156..1f975858c496 100644
> --- a/drivers/iio/adc/ad4851.c
> +++ b/drivers/iio/adc/ad4851.c
> @@ -319,8 +319,8 @@ static int ad4851_set_oversampling_ratio(struct iio_dev
> *indio_dev,
>  		if (ret)
>  			return ret;
>  	}
> -
> -	ret = iio_backend_oversampling_ratio_set(st->back, osr);
> +	/* Channel is ignored by the backend being used here */
> +	ret = iio_backend_oversampling_ratio_set(st->back, 0, osr);
>  	if (ret)
>  		return ret;
>  
> diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-
> backend.c
> index c1eb9ef9db08..a4e3e54fecb1 100644
> --- a/drivers/iio/industrialio-backend.c
> +++ b/drivers/iio/industrialio-backend.c
> @@ -720,9 +720,10 @@ EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set,
> "IIO_BACKEND");
>   * 0 on success, negative error number on failure.
>   */
>  int iio_backend_oversampling_ratio_set(struct iio_backend *back,
> +				       unsigned int chan,
>  				       unsigned int ratio)
>  {
> -	return iio_backend_op_call(back, oversampling_ratio_set, ratio);
> +	return iio_backend_op_call(back, oversampling_ratio_set, chan,
> ratio);
>  }
>  EXPORT_SYMBOL_NS_GPL(iio_backend_oversampling_ratio_set, "IIO_BACKEND");
>  
> diff --git a/include/linux/iio/backend.h b/include/linux/iio/backend.h
> index e59d909cb659..dbf4e4a5f4b1 100644
> --- a/include/linux/iio/backend.h
> +++ b/include/linux/iio/backend.h
> @@ -144,7 +144,7 @@ struct iio_backend_ops {
>  				  enum iio_backend_interface_type *type);
>  	int (*data_size_set)(struct iio_backend *back, unsigned int size);
>  	int (*oversampling_ratio_set)(struct iio_backend *back,
> -				      unsigned int ratio);
> +				      unsigned int chan, unsigned int ratio);
>  	int (*read_raw)(struct iio_backend *back,
>  			struct iio_chan_spec const *chan, int *val, int
> *val2,
>  			long mask);
> @@ -209,6 +209,7 @@ int iio_backend_interface_type_get(struct iio_backend
> *back,
>  				   enum iio_backend_interface_type *type);
>  int iio_backend_data_size_set(struct iio_backend *back, unsigned int size);
>  int iio_backend_oversampling_ratio_set(struct iio_backend *back,
> +				       unsigned int chan,
>  				       unsigned int ratio);
>  int iio_backend_read_raw(struct iio_backend *back,
>  			 struct iio_chan_spec const *chan, int *val, int
> *val2,