linux-kernel - [PATCH] crypto: tegra: Add crypto config in tegra_cmac_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250526020403.230-1-vulab@iscas.ac.cn>
Date: Mon, 26 May 2025 10:04:02 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: akhilrajeev@...dia.com,
	herbert@...dor.apana.org.au,
	davem@...emloft.net,
	thierry.reding@...il.com,
	jonathanh@...dia.com
Cc: linux-crypto@...r.kernel.org,
	linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>
Subject: [PATCH] crypto: tegra: Add crypto config in tegra_cmac_do_final()

The function tegra_cmac_do_final() calls the function tegra234_aes_cfg(),
but does not call tegra234_aes_crypto_cfg() to have a crypto
configuration. A proper implementation can be found in
tegra_ccm_do_ctr().

Add the tegra234_aes_crypto_cfg() for configuration.

Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 drivers/crypto/tegra/tegra-se-aes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-aes.c
index 9d130592cc0a..e01653985a31 100644
--- a/drivers/crypto/tegra/tegra-se-aes.c
+++ b/drivers/crypto/tegra/tegra-se-aes.c
@@ -1550,6 +1550,8 @@ static int tegra_cmac_do_final(struct ahash_request *req)
 	rctx->datbuf.size = rctx->residue.size;
 	rctx->total_len += rctx->residue.size;
 	rctx->config = tegra234_aes_cfg(SE_ALG_CMAC, 0);
+	rctx->crypto_config = tegra234_aes_crypto_cfg(SE_ALG_CMAC, 0) |
+		SE_AES_KEY_INDEX(ctx->key_id);
 
 	/* Prepare command and submit */
 	cmdlen = tegra_cmac_prep_cmd(ctx, rctx);
-- 
2.42.0.windows.2