linux-kernel - Re: [PATCH] crypto: tegra: Add crypto config in tegra_cmac_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aElJZAxSVEM4bwBI@gondor.apana.org.au>
Date: Wed, 11 Jun 2025 17:16:20 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: akhilrajeev@...dia.com, davem@...emloft.net, thierry.reding@...il.com,
	jonathanh@...dia.com, linux-crypto@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: tegra: Add crypto config in tegra_cmac_do_final()

On Mon, May 26, 2025 at 10:04:02AM +0800, Wentao Liang wrote:
> The function tegra_cmac_do_final() calls the function tegra234_aes_cfg(),
> but does not call tegra234_aes_crypto_cfg() to have a crypto
> configuration. A proper implementation can be found in
> tegra_ccm_do_ctr().
> 
> Add the tegra234_aes_crypto_cfg() for configuration.
> 
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/crypto/tegra/tegra-se-aes.c | 2 ++
>  1 file changed, 2 insertions(+)

So did this fail during the self-test? Please provide the before
and after self-test results.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt