linux-kernel - Re: [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a56za67l.fsf@trenco.lwn.net>
Date: Mon, 26 May 2025 06:48:14 -0600
From: Jonathan Corbet <corbet@....net>
To: Bagas Sanjaya <bagasdotme@...il.com>, George Anthony Vernon
 <contact@...rnon.com>, dmitry.torokhov@...il.com, skhan@...nel.org
Cc: linux-input@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting

Bagas Sanjaya <bagasdotme@...il.com> writes:

> On Mon, May 26, 2025 at 02:14:43AM +0100, George Anthony Vernon wrote:
>> Make small grammar fixes to Amiga joystick documentation.
>> 
>> Also make heading adornments compliant with the guidelines to improve
>> organisation of the page.
>
> Split up these two changes into separate patches.

The word "also" in a changelog is indeed a hint that a patch is doing
too many things.

For a simple patch like this, though, I would not force a resend just
for that.

>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> -Amiga joystick extensions
>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> +===============
>> +Amiga joysticks
>> +===============
>
> I would prefer to keep section adornments in this doc as-is, though.

...and why...?  We have a standard progression, why not use it?

jon