linux-kernel - Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b71bbef-84f6-4255-b8b2-cf50c5183235@kernel.org>
Date: Mon, 26 May 2025 14:56:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Mahapatra, Amit Kumar" <amit.kumar-mahapatra@....com>,
 Conor Dooley <conor@...nel.org>
Cc: "broonie@...nel.org" <broonie@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "git (AMD-Xilinx)" <git@....com>,
 "amitrkcian2002@...il.com" <amitrkcian2002@...il.com>
Subject: Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update
 minItems/maxItems of resets for Cadence OSPI controller

On 26/05/2025 09:07, Mahapatra, Amit Kumar wrote:
>>>    - if:
>>> @@ -132,11 +139,11 @@ properties:
>>>      maxItems: 1
>>>
>>>    resets:
>>> -    minItems: 2
>>> +    minItems: 1
>>
>> I think you're still missing one of the things Krzysztof requested on v1, cos you
>> reduce minItems for all platforms without restricting it back to 2 for non-versal
>> platforms.
> 
> I believe we can remove the "resets" and corresponding "reset-names"
> properties from here, as their default minItems/maxItems are already
> taken care of in the else block [1].
> 
> [1] https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L39
I don't see anything fixed there.

Best regards,
Krzysztof