linux-kernel - RE: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA0PR12MB76991D522A8E47DDA3800EE5DC64A@IA0PR12MB7699.namprd12.prod.outlook.com>
Date: Tue, 27 May 2025 06:05:36 +0000
From: "Mahapatra, Amit Kumar" <amit.kumar-mahapatra@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley <conor@...nel.org>
CC: "broonie@...nel.org" <broonie@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>,
	"amitrkcian2002@...il.com" <amitrkcian2002@...il.com>
Subject: RE: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update
 minItems/maxItems of resets for Cadence OSPI controller

[AMD Official Use Only - AMD Internal Distribution Only]

> Subject: Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems
> of resets for Cadence OSPI controller
>
> On 26/05/2025 09:07, Mahapatra, Amit Kumar wrote:
> >>>    - if:
> >>> @@ -132,11 +139,11 @@ properties:
> >>>      maxItems: 1
> >>>
> >>>    resets:
> >>> -    minItems: 2
> >>> +    minItems: 1
> >>
> >> I think you're still missing one of the things Krzysztof requested on
> >> v1, cos you reduce minItems for all platforms without restricting it
> >> back to 2 for non-versal platforms.
> >
> > I believe we can remove the "resets" and corresponding "reset-names"
> > properties from here, as their default minItems/maxItems are already
> > taken care of in the else block [1].
> >
> > [1]
> > https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14
> > ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L
> > 39
> I don't see anything fixed there.

The intention was to point out the redundancy related to the 'resets' and
'reset-names' properties. At [1], the default minItems and maxItems values
are already defined for all platforms. However, the same constraints are
redefined at [2] with different minItems and maxItems values , again
applying to all platforms. Based on my understanding, the definitions at
[2] for 'resets' and the corresponding 'reset-names' can be safely
removed.

[1] https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L41
[2] https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L139

Regards,
Amit

>
> Best regards,
> Krzysztof