linux-kernel - Re: [PATCHv4 3/5] dt-bindings: net: wireless: ath9k: add WIFI bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7145bfad-16d6-4445-bc19-261c5bdca8d9@kernel.org>
Date: Mon, 26 May 2025 06:26:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rosen Penev <rosenp@...il.com>, linux-wireless@...r.kernel.org
Cc: Toke Høiland-Jørgensen <toke@...e.dk>,
 nbd@....name, Johannes Berg <johannes@...solutions.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 "open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCHv4 3/5] dt-bindings: net: wireless: ath9k: add WIFI
 bindings

On 25/05/2025 23:42, Rosen Penev wrote:
> These are for the wireless chips that come built in with various
> Atheros/QCA SoCs. dts wise, the difference between pcie and the wmac is
> 
> AHB > PCIE > WIFI
> AHB > WIFI
> 
> These will be used to replace the platform_device code with OF in the
> following patch.

Drop the sentence. If we use auxiliary driver instead, should it
invalidate this commit msg?

> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  .../bindings/net/wireless/qca,ath9k.yaml       | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> index 0e5412cff2bc..68d56e5b8680 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> @@ -12,7 +12,7 @@ maintainers:
>  description: |
>    This node provides properties for configuring the ath9k wireless device.
>    The node is expected to be specified as a child node of the PCI controller
> -  to which the wireless chip is connected.
> +  or AHB bus to which the wireless chip is connected.
>  
>  allOf:
>    - $ref: ieee80211.yaml#
> @@ -35,6 +35,12 @@ properties:
>        - pci168c,0034  # AR9462
>        - pci168c,0036  # AR9565
>        - pci168c,0037  # AR1111 and AR9485
> +      - qcom,ar9130-wifi
> +      - qcom,ar9330-wifi
> +      - qcom,ar9340-wifi

I assume all these qr9xxx are capable of running Linux, thus you
document here other side - having them as part of other SoC.

> +      - qcom,qca9530-wifi
> +      - qcom,qca9550-wifi
> +      - qcom,qca9560-wifi

But what about these? As well? Do they have other interfaces? IOW,
suffix "-wifi" is added ONLY if there is "qcom,qca9530" or
"qcom,qca9530-foo" somewhere or possible.


Best regards,
Krzysztof