linux-kernel - Re: [PATCH v3 01/10] dt-bindings: iio: adc: Add AD4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDTkVFDNYeyIldBs@debian-BULLSEYE-live-builder-AMD64>
Date: Mon, 26 May 2025 18:59:48 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, lars@...afoo.de,
	Michael.Hennerich@...log.com, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, linus.walleij@...aro.org,
	brgl@...ev.pl
Subject: Re: [PATCH v3 01/10] dt-bindings: iio: adc: Add AD4170

Hi Jonathan,

I'm still working on the changes suggested for this set.
Just to mention, I've updated the dt-binding to declare only channel nodes under
the ADC node.

... 
> > +      adi,sensor-type:
> > +        description: |
> > +          Type of sensor connected to the device. Depending on the sensor type
> > +          (weigh scale, RTD, or thermocouple) the values of sensor-node
> > +          properties have slightly different constraints. This property
> > +          specifies which particular external sensor is connected to the ADC so
> > +          the sensor-node properties can be properly parsed and verified. The
> > +          possible sensor types are:
> > +          0: weigh scale;
> > +          1: RTD;
> > +          2: thermocouple.
> > +        $ref: /schemas/types.yaml#/definitions/uint8
> 
> I think this should be an enum of strings.  That will give us a clean
> way to extend it for other sensor types in future.
Ack

...
> > +
> > +  interrupts:
> > +    maxItems: 1
> 
> What if they are both wired?  At that point shouldn't software
> make up it's mind which to use?

Not sure I understand the concern here. Is 'interrupt-names' property expected
to precede 'interrupts' in dt-doc? For AD4170 and similar parts, the data
ready signal (/RDY) is by default provided on the SDO line after the completion
of a conversion. Alternatively, it can be provided on the DIG_AUX1 pin in
which case the chip disables the RDY function on SDO. So, there can only be one
data ready interrupt enabled at a time. Guess I'll add some description to make
clear only one interrupt can be enabled.

> > +
> > +  interrupt-names:
> > +    description:
> > +      Specify which pin should be configured as Data Ready interrupt.
> > +    enum:
> > +      - sdo
> > +      - dig_aux1
> > +    default: sdo
> > +

Thanks,
Marcelo