linux-kernel - Re: [PATCH] [net-next] hns3: Demote load and progress messages to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93f09b85-9e11-489c-9d7e-78ce057b6437@lunn.ch>
Date: Tue, 27 May 2025 21:50:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Jian Shen <shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
	Jijie Shao <shaojijie@...wei.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] [net-next] hns3: Demote load and progress messages to
 debug level

On Tue, May 27, 2025 at 09:30:15PM +0200, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> No driver should spam the kernel log when merely being loaded.
> The message in hclge_init() is clearly a debug message.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Alternatively, the printing in hns3_init_module() could be removed
> completely, but that would make hns3_driver_string[] and
> hns3_copyright[] unused, which HiSilicon legal may object against?

>From a IANAL perspective, pr_debug() is O.K. for me.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew