linux-kernel - Re: [PATCH] [net-next] hns3: Demote load and progress messages to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <012a9ce8-bc38-4b0b-b344-2e4a7a9a344e@huawei.com>
Date: Wed, 28 May 2025 16:04:41 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, Jian Shen
	<shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <shaojijie@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] [net-next] hns3: Demote load and progress messages to
 debug level


on 2025/5/28 3:30, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@...der.be>
>
> No driver should spam the kernel log when merely being loaded.
> The message in hclge_init() is clearly a debug message.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks,
Reviewed-by: Jijie Shao<shaojijie@...wei.com>

> ---
> Alternatively, the printing in hns3_init_module() could be removed
> completely, but that would make hns3_driver_string[] and
> hns3_copyright[] unused, which HiSilicon legal may object against?
> ---
>   drivers/net/ethernet/hisilicon/hns3/hns3_enet.c         | 4 ++--
>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index b03b8758c7774ec2..5c8c62ea6ac0429f 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -5961,8 +5961,8 @@ static int __init hns3_init_module(void)
>   {
>   	int ret;
>   
> -	pr_info("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
> -	pr_info("%s: %s\n", hns3_driver_name, hns3_copyright);
> +	pr_debug("%s: %s - version\n", hns3_driver_name, hns3_driver_string);
> +	pr_debug("%s: %s\n", hns3_driver_name, hns3_copyright);
>   
>   	client.type = HNAE3_CLIENT_KNIC;
>   	snprintf(client.name, HNAE3_CLIENT_NAME_LENGTH, "%s",
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> index 3e28a08934abd2e1..6bfff77ea7e67e8d 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -12904,7 +12904,7 @@ static struct hnae3_ae_algo ae_algo = {
>   
>   static int __init hclge_init(void)
>   {
> -	pr_info("%s is initializing\n", HCLGE_NAME);
> +	pr_debug("%s is initializing\n", HCLGE_NAME);
>   
>   	hclge_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, HCLGE_NAME);
>   	if (!hclge_wq) {