linux-kernel - Re: [PATCH] crypto: ccp: Fix dereferencing uninitialized error pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDebwj8rcuWPIKOa@gondor.apana.org.au>
Date: Thu, 29 May 2025 07:26:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Ashish Kalra <Ashish.Kalra@....com>
Cc: thomas.lendacky@....com, john.allen@....com, davem@...emloft.net,
	dan.carpenter@...aro.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: Fix dereferencing uninitialized error
 pointer

On Wed, May 28, 2025 at 08:20:18PM +0000, Ashish Kalra wrote:
>
> @@ -1320,10 +1322,10 @@ static int __sev_platform_init_locked(int *error)
>  
>  	/* Prepare for first SEV guest launch after INIT */
>  	wbinvd_on_all_cpus();
> -	rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, error);
> +	rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, &dfflush_error);
>  	if (rc) {
>  		dev_err(sev->dev, "SEV: DF_FLUSH failed %#x, rc %d\n",
> -			*error, rc);
> +			dfflush_error, rc);

dfflush_error is never returned to the caller unlike psp_ret, is
this intentional?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt