linux-kernel - Re: [PATCH v2] btrfs: harden parsing of compress mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250528232848.GM4037@twin.jikos.cz>
Date: Thu, 29 May 2025 01:28:49 +0200
From: David Sterba <dsterba@...e.cz>
To: David Sterba <dsterba@...e.cz>
Cc: Daniel Vacek <neelx@...e.com>, Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
	Nick Terrell <terrelln@...com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: harden parsing of compress mount option

On Thu, Apr 24, 2025 at 09:29:56PM +0200, David Sterba wrote:
> On Wed, Apr 23, 2025 at 03:22:19PM +0200, Daniel Vacek wrote:
> > Btrfs happily but incorrectly accepts the `-o compress=zlib+foo` and similar
> > options with any random suffix. Let's handle that correctly.
> 
> Please split the patch. Moving code and adding a fix obscures the fix.
> As we'll want to backport more than just the validation of ':' it
> makes more sense to do the full move first and then add the individual
> fixes on top of that. Thanks.

As we've discussed it, both ways how to split it are ok, so please first
factor out the code to a helper and the add the fix or any other
validation that would make sense. Thanks.