linux-kernel - Re: [PATCH v2 2/2] ethernet: eswin: Add eic7700 ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b975a3e-ae1c-4354-90db-1f8d7ff567d3@kernel.org>
Date: Wed, 28 May 2025 07:50:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: weishangjuan@...incomputing.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com, vladimir.oltean@....com,
 rmk+kernel@...linux.org.uk, yong.liang.choong@...ux.intel.com,
 prabhakar.mahadev-lad.rj@...renesas.com, inochiama@...il.com,
 jan.petrous@....nxp.com, jszhang@...nel.org, p.zabel@...gutronix.de,
 0x1207@...il.com, boon.khai.ng@...era.com,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Cc: ningyu@...incomputing.com, linmin@...incomputing.com,
 lizhi2@...incomputing.com
Subject: Re: [PATCH v2 2/2] ethernet: eswin: Add eic7700 ethernet driver

On 28/05/2025 06:16, weishangjuan@...incomputing.com wrote:
> +static int eswin_qos_probe(struct platform_device *pdev,
> +			   struct plat_stmmacenet_data *plat_dat,
> +			   struct stmmac_resources *stmmac_res)
> +{
> +	struct eswin_qos_priv *dwc_priv;
> +	u32 hsp_aclk_ctrl_offset;
> +	u32 hsp_aclk_ctrl_regset;
> +	u32 hsp_cfg_ctrl_offset;
> +	u32 eth_axi_lp_ctrl_offset;
> +	u32 eth_phy_ctrl_offset;
> +	u32 eth_phy_ctrl_regset;
> +	struct clk *clk_app;
> +	int ret;
> +	int err;
> +
> +	dwc_priv = devm_kzalloc(&pdev->dev, sizeof(*dwc_priv), GFP_KERNEL);
> +	if (!dwc_priv)
> +		return -ENOMEM;
> +
> +	if (device_property_read_u32(&pdev->dev, "id", &dwc_priv->dev_id))

NAK, you cannot have undocumented ABI. You did not test your DTS.

Best regards,
Krzysztof