linux-kernel - Re: [PATCH v2 3/3] spi: spi_amd: Update Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWTwcoFQz39uF0gJUT=X4yC=wn0gYGU5L+jW_JBj0WnGA@mail.gmail.com>
Date: Wed, 28 May 2025 09:32:02 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: broonie@...nel.org, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, krishnamoorthi.m@....com, 
	akshata.mukundshetty@....com
Subject: Re: [PATCH v2 3/3] spi: spi_amd: Update Kconfig dependencies

Hi Raju,

Thanks for your patch, which is now commit dbb79974193a2932 ("spi:
spi_amd: Update Kconfig dependencies") upstream.

On Fri, 16 May 2025 at 12:09, Raju Rangoju <Raju.Rangoju@....com> wrote:
> Add X86 and SPI_MEM as dependencies for the spi_amd driver to ensure it is
> built only on relevant platforms and with the required SPI memory
> framework.

This sounds like you are restricting the driver further (BTW, what are
"relevant platforms"?)...

> Co-developed-by: Akshata MukundShetty <akshata.mukundshetty@....com>
> Signed-off-by: Akshata MukundShetty <akshata.mukundshetty@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>

> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -1267,7 +1267,8 @@ config SPI_ZYNQMP_GQSPI
>  config SPI_AMD
>         tristate "AMD SPI controller"
>         depends on PCI
> -       depends on SPI_MASTER || COMPILE_TEST
> +       depends on SPI_MASTER || X86 || COMPILE_TEST

... but this broadens it instead?
And how can it be used on X86 if SPI_MASTER=n?

Seeing an ACPI match table in drivers/spi/spi-amd.c, perhaps you wanted
to have a dependency on ACPI (or X86 && ACPI) somewhere?

BTW, as you now have a single Kconfig symbol gating both spi-amd.c
and spi-amd-pci.c, this means you can no longer build spi-amd.c if
CONFIG_PCI=n.

> +       depends on SPI_MEM
>         help
>           Enables SPI controller driver for AMD SoC.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds