| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aDbHb4q44BWwHQpE@lore-desk>
Date: Wed, 28 May 2025 10:21:03 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Sean Wang <sean.wang@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Benjamin Larsson <benjamin.larsson@...exis.eu>,
linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/6] pinctrl: airoha: convert PHY LED GPIO to macro
> PHY LED GPIO pinctrl struct definition is very similar across the
> different 4 PHY and 2 LED and it can be generelized to a macro.
>
> To reduce code size, convert them to a common macro.
Acked-by: Lorenzo Bianconi <lorenzo@...nel.org>
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 570 ++++------------------
> 1 file changed, 82 insertions(+), 488 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index 8af9109db992..2b532334d759 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -1475,516 +1475,110 @@ static const struct airoha_pinctrl_func_group pwm_func_group[] = {
> },
> };
>
> +#define AIROHA_PINCTRL_PHY_LED(gpio, mux_val, map_mask, map_val) \
> + { \
> + .name = (gpio), \
> + .regmap[0] = { \
> + AIROHA_FUNC_MUX, \
> + REG_GPIO_2ND_I2C_MODE, \
> + (mux_val), \
> + (mux_val), \
> + }, \
> + .regmap[1] = { \
> + AIROHA_FUNC_MUX, \
> + REG_LAN_LED0_MAPPING, \
> + (map_mask), \
> + (map_val), \
> + }, \
> + .regmap_size = 2, \
> + }
> +
> static const struct airoha_pinctrl_func_group phy1_led0_func_group[] = {
> - {
> - .name = "gpio33",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED0_MODE_MASK,
> - GPIO_LAN0_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio34",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED0_MODE_MASK,
> - GPIO_LAN1_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio35",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED0_MODE_MASK,
> - GPIO_LAN2_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio42",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED0_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED0_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED0_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED0_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(0)),
> };
>
> static const struct airoha_pinctrl_func_group phy2_led0_func_group[] = {
> - {
> - .name = "gpio33",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED0_MODE_MASK,
> - GPIO_LAN0_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio34",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED0_MODE_MASK,
> - GPIO_LAN1_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio35",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED0_MODE_MASK,
> - GPIO_LAN2_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio42",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED0_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED0_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED0_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED0_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(1)),
> };
>
> static const struct airoha_pinctrl_func_group phy3_led0_func_group[] = {
> - {
> - .name = "gpio33",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED0_MODE_MASK,
> - GPIO_LAN0_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio34",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED0_MODE_MASK,
> - GPIO_LAN1_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio35",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED0_MODE_MASK,
> - GPIO_LAN2_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio42",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED0_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED0_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED0_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED0_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),
> };
>
> static const struct airoha_pinctrl_func_group phy4_led0_func_group[] = {
> - {
> - .name = "gpio33",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED0_MODE_MASK,
> - GPIO_LAN0_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio34",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED0_MODE_MASK,
> - GPIO_LAN1_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio35",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED0_MODE_MASK,
> - GPIO_LAN2_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio42",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED0_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED0_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(3)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED0_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(3)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED0_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(3)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED0_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(3)),
> };
>
> static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = {
> - {
> - .name = "gpio43",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED1_MODE_MASK,
> - GPIO_LAN0_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio44",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED1_MODE_MASK,
> - GPIO_LAN1_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio45",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED1_MODE_MASK,
> - GPIO_LAN2_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio46",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED1_MODE_MASK,
> - GPIO_LAN3_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(0)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED1_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED1_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED1_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(0)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED1_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(0)),
> };
>
> static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = {
> - {
> - .name = "gpio43",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED1_MODE_MASK,
> - GPIO_LAN0_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio44",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED1_MODE_MASK,
> - GPIO_LAN1_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio45",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED1_MODE_MASK,
> - GPIO_LAN2_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio46",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED1_MODE_MASK,
> - GPIO_LAN3_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(1)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED1_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED1_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED1_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(1)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED1_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(1)),
> };
>
> static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = {
> - {
> - .name = "gpio43",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED1_MODE_MASK,
> - GPIO_LAN0_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio44",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED1_MODE_MASK,
> - GPIO_LAN1_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio45",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED1_MODE_MASK,
> - GPIO_LAN2_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio46",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED1_MODE_MASK,
> - GPIO_LAN3_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(2)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED1_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED1_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED1_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED1_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),
> };
>
> static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = {
> - {
> - .name = "gpio43",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN0_LED1_MODE_MASK,
> - GPIO_LAN0_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN0_LED_MAPPING_MASK,
> - LAN0_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio44",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN1_LED1_MODE_MASK,
> - GPIO_LAN1_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN1_LED_MAPPING_MASK,
> - LAN1_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio45",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN2_LED1_MODE_MASK,
> - GPIO_LAN2_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN2_LED_MAPPING_MASK,
> - LAN2_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - }, {
> - .name = "gpio46",
> - .regmap[0] = {
> - AIROHA_FUNC_MUX,
> - REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED1_MODE_MASK,
> - GPIO_LAN3_LED1_MODE_MASK
> - },
> - .regmap[1] = {
> - AIROHA_FUNC_MUX,
> - REG_LAN_LED1_MAPPING,
> - LAN3_LED_MAPPING_MASK,
> - LAN3_PHY_LED_MAP(3)
> - },
> - .regmap_size = 2,
> - },
> + AIROHA_PINCTRL_PHY_LED("gpio33", GPIO_LAN0_LED1_MODE_MASK,
> + LAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio34", GPIO_LAN1_LED1_MODE_MASK,
> + LAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio35", GPIO_LAN2_LED1_MODE_MASK,
> + LAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),
> + AIROHA_PINCTRL_PHY_LED("gpio42", GPIO_LAN3_LED1_MODE_MASK,
> + LAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),
> };
>
> static const struct airoha_pinctrl_func en7581_pinctrl_funcs[] = {
> --
> 2.48.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists