[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <dd8f913d-1d6a-435b-b9b6-30a3d950e4a8@app.fastmail.com>
Date: Wed, 28 May 2025 13:27:33 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
"Christopher Snowhill" <chris@...e54.net>
Cc: "Lucas De Marchi" <lucas.demarchi@...el.com>,
"Arnd Bergmann" <arnd@...nel.org>,
Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@...el.com>, "Dave Airlie" <airlied@...il.com>,
"Simona Vetter" <simona@...ll.ch>, "Matthew Brost" <matthew.brost@...el.com>,
"Himal Prasad Ghimiray" <himal.prasad.ghimiray@...el.com>,
"Imre Deak" <imre.deak@...el.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
"Michael J. Ruhl" <michael.j.ruhl@...el.com>, intel-xe@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
dri-devel <dri-devel-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency
On Wed, May 28, 2025, at 12:31, Andy Shevchenko wrote:
> On Wed, May 28, 2025 at 03:17:03AM -0700, Christopher Snowhill wrote:
>> On Wed May 28, 2025 at 3:03 AM PDT, Arnd Bergmann wrote:
>> > On Wed, May 28, 2025, at 11:34, Andy Shevchenko wrote:
>> >> On Tue, May 27, 2025 at 03:55:46PM -0500, Lucas De Marchi wrote:
>> > I think ACPI_VIDEO is at the center here, and changing all the
>> > 'select ACPI_VIDEO if ACPI' instances to
>> > 'depends on ACPI_VIDEO || !ACPI_VIDEO' would solve a lot of
>>
>> Maybe you meant 'depends on ACPI_VIDEO || !ACPI' ?
>
> I believe not. The depends on FOO || FOO=n is idiomatic in Kconfig.
It depends on what we want here. 'ACPI_VIDEO || !ACPI' would
be the direct equivalent of the existing 'select ACPI_VIDEO if ACPI',
while 'ACPI_VIDEO || !ACPI_VIDEO' would allow building with
ACPI=y and ACPI_VIDEO=n, which is not possible today. I'd probably
start with the version that Christopher suggested to have a lower
regression risk.
Arnd
Powered by blists - more mailing lists