linux-kernel - Re: [PATCH v3 3/4] firmware: stratix10-svc: Add initial support for asynchronous communication with Stratix10 service channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e02b0ef-2470-454b-81df-810602d8a626@kernel.org>
Date: Wed, 28 May 2025 13:50:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mahesh Rao <mahesh.rao@...era.com>, Dinh Nguyen <dinguyen@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Matthew Gerlach <matthew.gerlach@...era.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 3/4] firmware: stratix10-svc: Add initial support for
 asynchronous communication with Stratix10 service channel

On 28/05/2025 12:29, Mahesh Rao wrote:
>> ...
>>
>>> +	args.a0 = INTEL_SIP_SMC_ASYNC_POLL;
>>> +	args.a1 =
>>> +		STRATIX10_SIP_SMC_SET_TRANSACTIONID_X1(handle->transaction_id);
>>> +
>>> +	actrl->invoke_fn(actrl, &args, &handle->res);
>>> +
>>> +	data->status = 0;
>>> +	if (handle->res.a0 == INTEL_SIP_SMC_STATUS_OK) {
>>> +		return 0;
>>> +	} else if (handle->res.a0 == INTEL_SIP_SMC_STATUS_BUSY) {
>>> +		dev_dbg(ctrl->dev, "async message is still in progress\n");
>>> +		return -EAGAIN;
>>> +	}
>>> +
>>> +	dev_err(ctrl->dev,
>>> +		"Failed to poll async message ,got status as %ld\n",
>>> +		handle->res.a0);
>>> +	return -EINVAL;
>>> +}
>>> +EXPORT_SYMBOL_GPL(stratix10_svc_async_poll);
>>
>> No, drop entire function. There is no user of it. You cannot add exports
>> for dead code.
> 
> These functions have been newly introduced for the Stratix10-SVC 
> platform driver. The client drivers that will utilize these APIs are 
> currently under development and are planned for inclusion in a 
> subsequent patch set. Would you prefer that I include a sample client 
> driver using these APIs in this patch set instead?

You must have user for every exported symbol. In the same patchset, usually.



Best regards,
Krzysztof