linux-kernel - Re: [PATCH] Bluetooth: BT Driver: mediatek: add gpio pin to reset bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a430a69-6182-4a34-b5df-5fd557411b68@kernel.org>
Date: Wed, 28 May 2025 14:07:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Von Dentz <luiz.dentz@...il.com>
Cc: Sean Wang <sean.wang@...iatek.com>, Deren Wu <deren.Wu@...iatek.com>,
 Aaron Hou <aaron.hou@...iatek.com>, Chris Lu <chris.lu@...iatek.com>,
 Steve Lee <steve.lee@...iatek.com>,
 linux-bluetooth <linux-bluetooth@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 linux-mediatek <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] Bluetooth: BT Driver: mediatek: add gpio pin to reset bt

On 28/05/2025 09:03, Zhangchao Zhang wrote:
> +
> +static int btmtk_reset_by_gpio(struct hci_dev *hdev)
> +{
> +	struct btmtk_data *data = hci_get_priv(hdev);
> +	struct btmtk_reset_gpio *reset_gpio_data;
> +	struct device_node *node;
> +	int reset_gpio_number;
> +
> +	node = of_find_compatible_node(NULL, NULL, "mediatek,usb-bluetooth");

There is no such compatible. Just git grep for it.

> +	if (node) {
> +		reset_gpio_number = of_get_named_gpio(node, "reset-gpios", 0);

Where is the ABI documented? Anyway, you should not pick GPIOs from
random devices.


Best regards,
Krzysztof