linux-kernel - Re: [PATCH] Bluetooth: BT Driver: mediatek: add gpio pin to reset bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451afb573ed6b218f2d8eeacdf1c3158c698c421.camel@mediatek.com>
Date: Wed, 25 Jun 2025 03:42:30 +0000
From: Chris Lu (陸稚泓) <Chris.Lu@...iatek.com>
To: Zhangchao Zhang (张超)
	<ot_zhangchao.zhang@...iatek.com>, "johan.hedberg@...il.com"
	<johan.hedberg@...il.com>, "luiz.dentz@...il.com" <luiz.dentz@...il.com>,
	"marcel@...tmann.org" <marcel@...tmann.org>, "krzk@...nel.org"
	<krzk@...nel.org>
CC: Sean Wang <Sean.Wang@...iatek.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>,
	Steve Lee (李視誠) <steve.lee@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Deren Wu (武德仁) <Deren.Wu@...iatek.com>,
	Aaron Hou (侯俊仰) <Aaron.Hou@...iatek.com>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH] Bluetooth: BT Driver: mediatek: add gpio pin to reset bt

Hi Krzysztof,

Sorry for late reply. Some problem with Zhangchao's envrionment that he
can't reply the mail. So I'll reply on his behalf.

Before submitting the next version, we'd like to discuss and confirm
the questions you mentioned in v1 according to the suggestion from
Bluetooth Maintainer Luiz.

On Wed, 2025-05-28 at 14:07 +0200, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 28/05/2025 09:03, Zhangchao Zhang wrote:
> > +
> > +static int btmtk_reset_by_gpio(struct hci_dev *hdev)
> > +{
> > +     struct btmtk_data *data = hci_get_priv(hdev);
> > +     struct btmtk_reset_gpio *reset_gpio_data;
> > +     struct device_node *node;
> > +     int reset_gpio_number;
> > +
> > +     node = of_find_compatible_node(NULL, NULL, "mediatek,usb-
> > bluetooth");
> 
> There is no such compatible. Just git grep for it.
> 
> > +     if (node) {
> > +             reset_gpio_number = of_get_named_gpio(node, "reset-
> > gpios", 0);
> 
> Where is the ABI documented? Anyway, you should not pick GPIOs from
> random devices.
> 
In v1, we haven't prepared yaml file about dts setting yet. Does your
question above referring to the same thing?

Zhangchao will add it in the next submission and run it through
"dt_binding_check" according to the Kernel's document.

> 
> Best regards,
> Krzysztof

Thanks a lot,
Chris Lu