linux-kernel - Re: [PATCH 14/17] pinctrl: renesas: Move fixed assignments to 'pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUGDf5n_Fg7pwiPumm95nPUXyH15geAy2ULwY3U+OtZJA@mail.gmail.com>
Date: Wed, 28 May 2025 14:54:41 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Basavaraj Natikar <Basavaraj.Natikar@....com>, 
	Shyam Sundar S K <Shyam-sundar.S-k@....com>, Andrew Jeffery <andrew@...econstruct.com.au>, 
	Joel Stanley <joel@....id.au>, Avi Fishman <avifishman70@...il.com>, 
	Tomer Maimon <tmaimon77@...il.com>, Tali Perry <tali.perry1@...il.com>, 
	Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, 
	Benjamin Fair <benjaminfair@...gle.com>, Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Rafał Miłecki <rafal@...ecki.pl>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	David Rhodes <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
	Charles Keepax <ckeepax@...nsource.cirrus.com>, Lorenzo Bianconi <lorenzo@...nel.org>, 
	Sean Wang <sean.wang@...nel.org>, Jesper Nilsson <jesper.nilsson@...s.com>, 
	Lars Persson <lars.persson@...s.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Damien Le Moal <dlemoal@...nel.org>, 
	Vladimir Zapolskiy <vz@...ia.com>, Michal Simek <michal.simek@....com>, 
	Emil Renner Berthing <kernel@...il.dk>, Jianlong Huang <jianlong.huang@...rfivetech.com>, 
	Hal Feng <hal.feng@...rfivetech.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org, 
	openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org, 
	linux-renesas-soc@...r.kernel.org, linux-sound@...r.kernel.org, 
	patches@...nsource.cirrus.com, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...s.com, linux-riscv@...ts.infradead.org, 
	linux-rtc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 14/17] pinctrl: renesas: Move fixed assignments to
 'pinctrl_desc' definition

Hi Krzysztof,

On Wed, 28 May 2025 at 12:42, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> Assign 'struct pinctrl_desc' .pins and .npins members in definition to
> make clear that number of pins is fixed and have less code in the probe.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

> --- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
> @@ -680,6 +680,8 @@ static struct pinctrl_desc rzn1_pinctrl_desc = {

This structure could be made const...

>         .pmxops = &rzn1_pmx_ops,
>         .confops = &rzn1_pinconf_ops,
>         .owner = THIS_MODULE,
> +       .pins = rzn1_pins,
> +       .npins = ARRAY_SIZE(rzn1_pins),
>  };
>
>  static int rzn1_pinctrl_parse_groups(struct device_node *np,
> @@ -878,8 +880,6 @@ static int rzn1_pinctrl_probe(struct platform_device *pdev)
>
>         ipctl->dev = &pdev->dev;
>         rzn1_pinctrl_desc.name = dev_name(&pdev->dev);

... if you would replace this assignment by a hardcoded name
like "pinctrl-rzn1".

> -       rzn1_pinctrl_desc.pins = rzn1_pins;
> -       rzn1_pinctrl_desc.npins = ARRAY_SIZE(rzn1_pins);
>
>         ret = rzn1_pinctrl_probe_dt(pdev, ipctl);
>         if (ret) {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds