linux-kernel - Re: [PATCH net-next] net: phy: Add c45_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDcKvwDaa6_1gZY7@shell.armlinux.org.uk>
Date: Wed, 28 May 2025 14:08:15 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: Andrew Lunn <andrew@...n.ch>, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Add c45_phy_ids sysfs entry

On Mon, May 26, 2025 at 08:52:12AM +0000, Yajun Deng wrote:
> May 26, 2025 at 4:19 PM, "Russell King (Oracle)" <linux@...linux.org.uk> wrote:
> > On Mon, May 26, 2025 at 08:11:21AM +0000, Yajun Deng wrote:
> > >  $ ls /sys/class/net/eth0/phydev/c45_phy_ids
> > > 
> > >  mmd10_device_id mmd17_device_id mmd23_device_id mmd2_device_id mmd7_device_id
> > > 
> > >  mmd11_device_id mmd18_device_id mmd24_device_id mmd30_device_id mmd8_device_id
> > > 
> > >  mmd12_device_id mmd19_device_id mmd25_device_id mmd31_device_id mmd9_device_id
> > > 
> > >  mmd13_device_id mmd1_device_id mmd26_device_id mmd3_device_id
> > > 
> > >  mmd14_device_id mmd20_device_id mmd27_device_id mmd4_device_id
> > > 
> > >  mmd15_device_id mmd21_device_id mmd28_device_id mmd5_device_id
> > > 
> > >  mmd16_device_id mmd22_device_id mmd29_device_id mmd6_device_id
> > > 
> > 
> > I suspect you don't have a PHY that defines all these IDs. Are you sure
> > 
> > your .is_visible() is working properly?
> > 
> 
> I'm just determining if it's a c45 device and not filtering PHY ID content now.
> I can add this condition. 

I'm talking about listing all 31 entries, whether they're implemented in
the PHY or not. Look at mmds_present in struct phy_c45_device_ids to
determine which IDs should be exported as well as checking whether the
ID value you're exporting is not 0 or ~0.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!