linux-kernel - Re: [PATCH v13 16/27] x86/resctrl: Pass entire struct rdtgroup rather than passing individual members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aaa13f8-9b60-467e-9dd3-bf9fecf60458@amd.com>
Date: Thu, 29 May 2025 13:07:46 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tony.luck@...el.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: james.morse@....com, dave.martin@....com, fenghuay@...dia.com,
 x86@...nel.org, hpa@...or.com, paulmck@...nel.org,
 akpm@...ux-foundation.org, thuth@...hat.com, rostedt@...dmis.org,
 ardb@...nel.org, gregkh@...uxfoundation.org, daniel.sneddon@...ux.intel.com,
 jpoimboe@...nel.org, alexandre.chartre@...cle.com,
 pawan.kumar.gupta@...ux.intel.com, thomas.lendacky@....com,
 perry.yuan@....com, seanjc@...gle.com, kai.huang@...el.com,
 xiaoyao.li@...el.com, kan.liang@...ux.intel.com, xin3.li@...el.com,
 ebiggers@...gle.com, xin@...or.com, sohil.mehta@...el.com,
 andrew.cooper3@...rix.com, mario.limonciello@....com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 peternewman@...gle.com, maciej.wieczor-retman@...el.com, eranian@...gle.com,
 Xiaojian.Du@....com, gautham.shenoy@....com
Subject: Re: [PATCH v13 16/27] x86/resctrl: Pass entire struct rdtgroup rather
 than passing individual members

Hi Reinette,

On 5/22/25 18:05, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/15/25 3:52 PM, Babu Moger wrote:
>> The mbm_cntr_assign mode requires a cntr_id to read event data. The
> 
> cntr_id -> "counter ID"
> 

Sure.

>> cntr_id is retrieved via mbm_cntr_get, which takes a struct rdtgroup as
> 
> cntr_id -> "counter ID"
>

Sure.


> mbm_cntr_get -> mbm_cntr_get()
> 

Sure.

>> a parameter.
>>
>> Passing the full rdtgroup also provides access to closid and rmid, both of
> 
> closid -> CLOSID
> rmid -> RMID
> 

Sure.
>> which are necessary to read monitoring events.
>>
>> Refactor the code to pass the entire struct rdtgroup instead of individual
> 
> "the entire" -> "a pointer to"
> 

Sure.

>> members in preparation for this requirement.
>>
>> Suggested-by: Reinette Chatre <reinette.chatre@...el.com>
>> Signed-off-by: Babu Moger <babu.moger@....com>
>> ---
> Patch looks good.-- 
Thanks
Babu Moger