linux-kernel - Re: [PATCH v4 1/3] rust: implement `Wrapper<T>` for `Opaque<T>`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDomlACshW4beFj_@pollux>
Date: Fri, 30 May 2025 23:43:48 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Christian Schrefl <chrisi.schrefl@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lee Jones <lee@...nel.org>,
	Daniel Almeida <daniel.almeida@...labora.com>,
	Benno Lossin <lossin@...nel.org>,
	Gerald Wisböck <gerald.wisboeck@...ther.ink>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] rust: implement `Wrapper<T>` for `Opaque<T>`

On Fri, May 30, 2025 at 10:53:21PM +0200, Christian Schrefl wrote:
> On 30.05.25 10:46 PM, Christian Schrefl wrote:
> > Moves the implementation for `pin-init` from an associated function
> > to the trait function of the `Wrapper` trait and extends the
> > implementation to support pin-initializers with error types.
> > 
> > Adds a use for the `Wrapper` trait in `revocable.rs`, to use the new
> > `pin-init` function. This is currently the only usage in the kernel.
> > 
> > Reviewed-by: Gerald Wisböck <gerald.wisboeck@...ther.ink>
> > Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> > Reviewed-by: Benno Lossin <lossin@...nel.org>
> > Signed-off-by: Christian Schrefl <chrisi.schrefl@...il.com>
> > ---
> 
> Danilo, FYI this is basically a patch from my `UnsafePinned`
> series [0] that I've used instead of your patch [1] that does something similar.
> (I've only dropped `the call is infallible` from the safety
> comment like in your patch since I missed that before).
> 
> Let me know if you want me to handle this any different.

No, that's fine, I wasn't aware of this patch, let's go with this one then.

	Reviewed-by: Danilo Krummrich <dakr@...nel.org>

> [0]: https://lore.kernel.org/rust-for-linux/20250511-rust_unsafe_pinned-v4-2-a86c32e47e3d@gmail.com/
> [1]: https://lore.kernel.org/rust-for-linux/20250530142447.166524-2-dakr@kernel.org/