linux-kernel - Re: [PATCH v7 0/9] More Rust bindings for device property reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA9TOWRKLFUF.3AWTUTNDPI8OR@buenzli.dev>
Date: Fri, 30 May 2025 23:45:38 +0200
From: "Remo Senekowitsch" <remo@...nzli.dev>
To: "Danilo Krummrich" <dakr@...nel.org>
Cc: "Rob Herring" <robh@...nel.org>, "Saravana Kannan"
 <saravanak@...gle.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 "Dirk Behme" <dirk.behme@...bosch.com>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v7 0/9] More Rust bindings for device property reads

On Fri May 30, 2025 at 9:56 PM CEST, Danilo Krummrich wrote:
> On Fri, May 30, 2025 at 09:28:47PM +0200, Remo Senekowitsch wrote:
>> changes in v7:
>> * Fix a typo in a commit message.
>> * Fix bug in `FwNode::display_path`. I took a slightly different
>>   approach than the one suggested, using `Either` to handle the
>>   owned and borrowed case. That also removes the conditional
>>   `fwnode_handle_put` at the end.
>
> That's a good idea, but also a bit unfortunate; there are efforts to remove
> Either [1] in favor of using - more descriptive - custom enum types.
>
> Can you please replace this with e.g. an enum Node with a Borrowed and Owned
> variant?
>
> [1] https://lore.kernel.org/lkml/20250519124304.79237-1-lossin@kernel.org/

Sure, that seems reasonable.

Btw. what's the normal waiting time before posting a new version of a
patch series? The requested changes have been getting fewer and I could
crank these out much faster, but my gut feeling tells me not to spam the
list too much. Or is that wrong and people can deal with quick updates
just fine?

Best regards,
Remo