linux-kernel - Re: [PATCH 2/3] i2c: amd-isp: Initialize unique adpater name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8670fa5f-5bf6-7dfe-1ec7-5cd1ec4472aa@linux.intel.com>
Date: Sat, 31 May 2025 08:06:58 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Pratap Nirujogi <pratap.nirujogi@....com>
cc: rdunlap@...radead.org, Hans de Goede <hdegoede@...hat.com>, 
    sfr@...b.auug.org.au, linux-next@...r.kernel.org, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    benjamin.chan@....com, bin.du@....com, gjorgji.rosikopulos@....com, 
    king.li@....com, dantony@....com
Subject: Re: [PATCH 2/3] i2c: amd-isp: Initialize unique adpater name

Hi Pratap,

Please send the next version(s) to all relevant people as indicated by 
scripts/get_maintainer.pl.

On Fri, 30 May 2025, Pratap Nirujogi wrote:

> Initialize unique name for amdisp i2c adapter, which is used
> in the platform driver to detect the matching adapter for
> i2c_client creation.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@....com>
> ---
>  drivers/i2c/busses/i2c-designware-amdisp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c
> index ad6f08338124..e8cb3785c740 100644
> --- a/drivers/i2c/busses/i2c-designware-amdisp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdisp.c
> @@ -62,6 +62,8 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev)
>  
>  	adap = &isp_i2c_dev->adapter;
>  	adap->owner = THIS_MODULE;
> +	snprintf(adap->name, sizeof(adap->name),
> +		 "AMDISP DesignWare I2C adapter");

scnprintf() is preferrable over snprintf(). Even if you don't use the 
return value here, eventually somebody will want to get rid of snprintf() 
entirely so lets try not add new ones.

>  	ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
>  	adap->dev.of_node = pdev->dev.of_node;
>  	/* use dynamically allocated adapter id */
> 

-- 
 i.