[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea615c2e-d306-06b2-10b0-2423ab59a8e9@linux.intel.com>
Date: Sat, 31 May 2025 08:11:48 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Pratap Nirujogi <pratap.nirujogi@....com>
cc: rdunlap@...radead.org, Hans de Goede <hdegoede@...hat.com>,
sfr@...b.auug.org.au, linux-next@...r.kernel.org,
platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
benjamin.chan@....com, bin.du@....com, gjorgji.rosikopulos@....com,
king.li@....com, dantony@....com
Subject: Re: [PATCH 3/3] platform/x86: Use i2c adapter name to fix build
errors
On Fri, 30 May 2025, Pratap Nirujogi wrote:
> Use 'adapater->name' inplace of 'adapter->owner->name' to fix build issues
> when CONFIG_MODULES is not defined.
>
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
This is the which should have this Fixes tag, the other commits should not
have it as they're not really the fix (but this change just depends on
them, but since stable is not in picture yet for this driver we don't
need to indicate even those deps).
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@....com>
> ---
> drivers/platform/x86/amd/amd_isp4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
> index 0cc01441bcbb..80b57b58621a 100644
> --- a/drivers/platform/x86/amd/amd_isp4.c
> +++ b/drivers/platform/x86/amd/amd_isp4.c
> @@ -151,7 +151,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>
> static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
> {
> - return !strcmp(adap->owner->name, "i2c_designware_amdisp");
> + return !strcmp(adap->name, "AMDISP DesignWare I2C adapter");
Since both are in-kernel code, share that name through a define in some
header.
--
i.
Powered by blists - more mailing lists