[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e75a0e17-8a1b-14f0-a33d-e59c0f692651@linux.intel.com>
Date: Sat, 31 May 2025 08:14:53 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Pratap Nirujogi <pratap.nirujogi@....com>
cc: rdunlap@...radead.org, Hans de Goede <hdegoede@...hat.com>,
sfr@...b.auug.org.au, linux-next@...r.kernel.org,
platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
benjamin.chan@....com, bin.du@....com, gjorgji.rosikopulos@....com,
king.li@....com, dantony@....com
Subject: Re: [PATCH 1/3] i2c: designware: Initialize adapter name only when
not set
On Fri, 30 May 2025, Pratap Nirujogi wrote:
> Check if the adapter name is already set in the driver prior
> to initializing with generic name in i2c_dw_probe_master().
>
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@....com>
> ---
> drivers/i2c/busses/i2c-designware-master.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index c5394229b77f..ab03943d6aaf 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -1042,8 +1042,9 @@ int i2c_dw_probe_master(struct dw_i2c_dev *dev)
> if (ret)
> return ret;
>
> - snprintf(adap->name, sizeof(adap->name),
> - "Synopsys DesignWare I2C adapter");
> + if (!adap->name[0])
> + snprintf(adap->name, sizeof(adap->name),
> + "Synopsys DesignWare I2C adapter");
I'd convert this to scnprintf() here as well and add to the changelog:
While at it, convert to scnprintf() that is preferred over snprintf().
As with the other patch, this too is missing receipients (as indicated
by the get_maintainers script).
--
i.
Powered by blists - more mailing lists