linux-kernel - Re: [PATCH] crypto/crc32: register only one shash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDqrMb7U18DcMSRl@gondor.apana.org.au>
Date: Sat, 31 May 2025 15:09:37 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	ardb@...nel.org
Subject: Re: [PATCH] crypto/crc32: register only one shash_alg

Eric Biggers <ebiggers@...nel.org> wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Stop unnecessarily registering a "crc32-generic" shash_alg when a
> "crc32-$(ARCH)" shash_alg is registered too.
> 
> While every algorithm does need to have a generic implementation to
> ensure uniformity of support across platforms, that doesn't mean that we
> need to make the generic implementation available through crypto_shash
> when an optimized implementation is also available.
> 
> Registering the generic shash_alg did allow users of the crypto_shash or
> crypto_ahash APIs to request the generic implementation specifically,
> instead of an optimized one.  However, the only known use case for that
> was the differential fuzz tests in crypto/testmgr.c.  Equivalent test
> coverage is now provided by crc_kunit.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> I'm planning to take this through the crc tree.
> 
> crypto/crc32.c | 69 ++++++++------------------------------------------
> 1 file changed, 11 insertions(+), 58 deletions(-)

Please don't do this without first removing all drivers providing
"crc32" as otherwise their test coverge will be reduced.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt