linux-kernel - Re: [PATCH] userns: Add forward declaration of struct seq_file in user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDqq4rg9rTKRur8Y@gondor.apana.org.au>
Date: Sat, 31 May 2025 15:08:18 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] userns: Add forward declaration of struct seq_file in
 user_namespace.h

On Fri, May 30, 2025 at 08:27:14AM -0500, Eric W. Biederman wrote:
>
> That description seems to be lacking something.  The code as has been
> fine since 2014 and there is no conditional compilation involved.

I'm happy to drop the fixes header.  There is no need to backport
this.

> Did some other change cause a declaration of seq_file not to be present?
> Did user_namespace.h get included somewhere new and that new location
> doesn't wind up declaring seq_file?

The seq_file forward declaration is currently being provided by
linux/sched.h.  I tried removing it and found this issue.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt