linux-kernel - Re: [PATCH] userns: Add forward declaration of struct seq_file in user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877c1xghsn.fsf@email.froward.int.ebiederm.org>
Date: Sat, 31 May 2025 06:07:20 -0500
From: "Eric W. Biederman" <ebiederm@...ssion.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,  Andrew Morton
 <akpm@...ux-foundation.org>
Subject: Re: [PATCH] userns: Add forward declaration of struct seq_file in
 user_namespace.h

Herbert Xu <herbert@...dor.apana.org.au> writes:

> On Fri, May 30, 2025 at 08:27:14AM -0500, Eric W. Biederman wrote:
>>
>> That description seems to be lacking something.  The code as has been
>> fine since 2014 and there is no conditional compilation involved.
>
> I'm happy to drop the fixes header.  There is no need to backport
> this.

The fixes tag isn't wrong.

>> Did some other change cause a declaration of seq_file not to be present?
>> Did user_namespace.h get included somewhere new and that new location
>> doesn't wind up declaring seq_file?
>
> The seq_file forward declaration is currently being provided by
> linux/sched.h.  I tried removing it and found this issue.

Thanks.

That is the interesting information that I would appreciate to see
in the change log.

If someone has to play code archaeologist and has to look at the
history, this is exactly the information that is needed to understand
why the change was made.

Eric