linux-kernel - Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a126ee43-3e2e-4cbf-9c36-c41415df78af@kernel.org>
Date: Sun, 1 Jun 2025 16:50:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 kernel@....qualcomm.com, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for
 ADSP solution

On 01/06/2025 14:45, Prasad Kumpatla wrote:
>>>         properties:
>>>           clocks:
>>> -          maxItems: 1
>>> +          minItems: 1
>>> +          maxItems: 3
>>>           clock-names:
>>> -          items:
>>> -            - const: mclk
>>> +          oneOf:
>>> +            - items:   # for ADSP based platforms
>>> +                - const: mclk
>>> +                - const: macro
>>> +                - const: dcodec
>>> +            - items:   # for ADSP bypass based platforms
>>> +                - const: mclk
>>
>> This device always receives same amount of clocks. Hardware is not
>> different if you decide to not use ADSP.
> for sc7280 clock handling only supports non-DSP based solution, macro

ONLY?

> and dcodec votes are placed using CPU-Powerdomains. Which are not under
> clocking properties. In ADSP based platforms macro and dcodec votes 
> should be placed from ADSP.>

I don't understand this, that's barely a sentence. Anyway if that's
ONLY, then seems pretty fixed and I don't get why you make it flexible.

Expressing clocks as CPU powerdomains is not really correct.



Best regards,
Krzysztof