linux-kernel - Re: [PATCH v4 0/5] Allow dyn MSI-X vector allocation of MANA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83244641-8fab-4f05-9d31-c5881fa1660c@linux.dev>
Date: Sun, 1 Jun 2025 16:53:31 +0200
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, Nipun Gupta <nipun.gupta@....com>,
 Yury Norov <yury.norov@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Jonathan Cameron <Jonathan.Cameron@...ei.com>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Kevin Tian <kevin.tian@...el.com>, Long Li <longli@...rosoft.com>,
 Thomas Gleixner <tglx@...utronix.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Rob Herring <robh@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Krzysztof Wilczy�~Dski <kw@...ux.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
 Wei Liu <wei.liu@...nel.org>, Haiyang Zhang <haiyangz@...rosoft.com>,
 "K. Y. Srinivasan" <kys@...rosoft.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Konstantin Taranov <kotaranov@...rosoft.com>, Simon Horman
 <horms@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Maxim Levitsky <mlevitsk@...hat.com>,
 Erni Sri Satya Vennela <ernis@...ux.microsoft.com>,
 Peter Zijlstra <peterz@...radead.org>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, Paul Rosswurm <paulros@...rosoft.com>,
 Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH v4 0/5] Allow dyn MSI-X vector allocation of MANA

在 2025/5/27 17:57, Shradha Gupta 写道:
> In this patchset we want to enable the MANA driver to be able to
> allocate MSI-X vectors in PCI dynamically.
> 
> The first patch exports pci_msix_prepare_desc() in PCI to be able to
> correctly prepare descriptors for dynamically added MSI-X vectors.
> 
> The second patch adds the support of dynamic vector allocation in
> pci-hyperv PCI controller by enabling the MSI_FLAG_PCI_MSIX_ALLOC_DYN
> flag and using the pci_msix_prepare_desc() exported in first patch.
> 
> The third patch adds a detailed description of the irq_setup(), to
> help understand the function design better.
> 
> The fourth patch is a preparation patch for mana changes to support
> dynamic IRQ allocation. It contains changes in irq_setup() to allow
> skipping first sibling CPU sets, in case certain IRQs are already
> affinitized to them.
> 
> The fifth patch has the changes in MANA driver to be able to allocate
> MSI-X vectors dynamically. If the support does not exist it defaults to
> older behavior.
> ---
>   Change in v4
>   * add a patch describing the functionality of irq_setup() through a
>     comment
>   * In irq_setup(), avoid using a label next_cpumask:
>   * modify the changes in MANA patch about restructuring the error
>     handling path in mana_gd_setup_dyn_irqs()
>   * modify the mana_gd_setup_irqs() to simplify handling around
>     start_irq_index
>   * add warning if an invalid gic is returned
>   * place the xa_destroy() cleanup in mana_gd_remove
> ---
>   Changes in v3
>   * split the 3rd patch into preparation patch around irq_setup() and
>     changes in mana driver to allow dynamic IRQ allocation
>   * Add arm64 support for dynamic MSI-X allocation in pci_hyperv
>     controller
> ---
>   Changes in v2
>   * split the first patch into two(exporting the preapre_desc
>     func and using the function and flag in pci-hyperv)
>   * replace 'pci vectors' by 'MSI-X vectors'
>   * Change the cover letter description to align with changes made
> ---
> 
> Shradha Gupta (5):
>    PCI/MSI: Export pci_msix_prepare_desc() for dynamic MSI-X allocations
>    PCI: hv: Allow dynamic MSI-X vector allocation
>    net: mana: explain irq_setup() algorithm
>    net: mana: Allow irq_setup() to skip cpus for affinity
>    net: mana: Allocate MSI-X vectors dynamically

In this patchset, base-commit seems missing.

Please see this link:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15#n868

"
When you open ``outgoing/0000-cover-letter.patch`` for editing, you will
notice that it will have the ``base-commit:`` trailer at the very
bottom, which provides the reviewer and the CI tools enough information
to properly perform ``git am`` without worrying about conflicts::
"

When creating patches:
"
git format-patch --base=main origin/main
"

This will include a base-commit: line in each patch file:

"
base-commit: abcdef1234567890...
"

This is useful when submitting patches to mailing lists or other tooling.

Please follow the submitting-patches.rst to add base-commit.

Best Regards,
Zhu Yanjun

> 
>   .../net/ethernet/microsoft/mana/gdma_main.c   | 356 ++++++++++++++----
>   drivers/pci/controller/pci-hyperv.c           |   5 +-
>   drivers/pci/msi/irqdomain.c                   |   5 +-
>   include/linux/msi.h                           |   2 +
>   include/net/mana/gdma.h                       |   8 +-
>   5 files changed, 293 insertions(+), 83 deletions(-)
>