linux-kernel - Re: [PATCH v3 0/2] Add driver for Intel Over-Clocking Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDy09SFPkzr2AJnr@surfacebook.localdomain>
Date: Sun, 1 Jun 2025 23:15:49 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Diogo Ivo <diogo.ivo@...mens.com>, mika.westerberg@...ux.intel.com
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-watchdog@...r.kernel.org,
	jan.kiszka@...mens.com, benedikt.niedermayr@...mens.com
Subject: Re: [PATCH v3 0/2] Add driver for Intel Over-Clocking Watchdog

Mon, Mar 17, 2025 at 10:55:05AM +0000, Diogo Ivo kirjoitti:

+ Mika

> This series adds a driver for the Intel Over-Clocking Watchdog found in
> the Intel Platform Controller Hub (PCH).
> 
> This watchdog is controlled via a simple single-register interface and
> would otherwise be standard except for the presence of a LOCK bit that
> can only be set once per power cycle, needing extra handling around it.
> 
> Due to the way these devices are described in ACPI tables with both the
> generic PNP0C02 CID and a more detailed ACPI HID we also need to add
> their HIDs to the list of known non-PNP devices. As there are several HIDs
> for what seems to be essentially the same hardware but I don't know all
> the possible HIDs this series does not include an exhaustive list of all
> such HIDs, only those that I could personally test.

This doesn't describe why we need the driver. We have established ACPI WDAT
table. Can't you utilise it by providing in the firmware?

-- 
With Best Regards,
Andy Shevchenko