linux-kernel - Re: [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD28MuVP8MgvKMmt@smile.fi.intel.com>
Date: Mon, 2 Jun 2025 17:58:58 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
	Dragos Bogdan <dragos.bogdan@...log.com>,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Tobias Sperling <tobias.sperling@...ting.com>,
	Alisa-Dariana Roman <alisadariana@...il.com>,
	Marcelo Schmitt <marcelo.schmitt@...log.com>,
	Herve Codina <herve.codina@...tlin.com>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/5] iio: backend: update
 iio_backend_oversampling_ratio_set

On Mon, Jun 02, 2025 at 04:43:40PM +0300, Pop Ioan Daniel wrote:
> Add chan parameter to iio_backend_oversampling_ratio_set() to allow
> for contexts where the channel must be specified. Modify all
> existing users.

...

> static int ad4851_set_oversampling_ratio(struct iio_dev *indio_dev,

>  		if (ret)
>  			return ret;
>  	}

> -

Why do you remove this blank line? To me these two blocks do not look toughly
coupled.

> -	ret = iio_backend_oversampling_ratio_set(st->back, osr);
> +	/* Channel is ignored by the backend being used here */
> +	ret = iio_backend_oversampling_ratio_set(st->back, 0, osr);
>  	if (ret)
>  		return ret;

-- 
With Best Regards,
Andy Shevchenko