linux-kernel - Re: [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD28vs2_NA1jyPCE@smile.fi.intel.com>
Date: Mon, 2 Jun 2025 18:01:18 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
	Dragos Bogdan <dragos.bogdan@...log.com>,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Tobias Sperling <tobias.sperling@...ting.com>,
	Alisa-Dariana Roman <alisadariana@...il.com>,
	Marcelo Schmitt <marcelo.schmitt@...log.com>,
	Thomas Bonnefille <thomas.bonnefille@...tlin.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] iio: adc: ad7405: add ad7405 driver

On Mon, Jun 02, 2025 at 04:43:43PM +0300, Pop Ioan Daniel wrote:
> Add support for the AD7405/ADUM770x, a high performance isolated ADC,
> 1-channel, 16-bit with a second-order Σ-Δ modulator that converts an
> analog input signal into a high speed, single-bit data stream.

...

> +#include <linux/clk.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/util_macros.h>
> +#include <linux/mutex.h>

You need to follow IFYU (Include What You Use) principle, at a glance there are
a few missing. Also make them ordered. I guess I have commented on this already
and my comment was ignored for no reason.

-- 
With Best Regards,
Andy Shevchenko