linux-kernel - Re: [PATCH] samples: vfio-mdev: mtty.c: delete MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250602094334.4995ea23.alex.williamson@redhat.com>
Date: Mon, 2 Jun 2025 09:43:34 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: Xose Vazquez Perez <xose.vazquez@...il.com>
Cc: Kirti Wankhede <kwankhede@...dia.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>, KVM ML <kvm@...r.kernel.org>, KERNEL ML
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] samples: vfio-mdev: mtty.c: delete MODULE_VERSION

On Sat, 31 May 2025 18:18:36 +0200
Xose Vazquez Perez <xose.vazquez@...il.com> wrote:

> Reminiscence of ancient times when modules were developed outside the kernel.

s/Reminiscence/Reminiscent/

I think there are likely better arguments that could be made for
removal though, ex. citing specific policies or discussions.

> Cc: Kirti Wankhede <kwankhede@...dia.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: KVM ML <kvm@...r.kernel.org>
> Cc: KERNEL ML <linux-kernel@...r.kernel.org>

Signed-off-by?

See Developer's Certificate of Origin:
Documentation/process/submitting-patches.rst

Thanks,
Alex

> ---
>  samples/vfio-mdev/mtty.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index 59eefe2fed10..f9f7472516c9 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -35,7 +35,6 @@
>   * #defines
>   */
>  
> -#define VERSION_STRING  "0.1"
>  #define DRIVER_AUTHOR   "NVIDIA Corporation"
>  
>  #define MTTY_CLASS_NAME "mtty"
> @@ -2057,5 +2056,4 @@ module_exit(mtty_dev_exit)
>  
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
> -MODULE_VERSION(VERSION_STRING);
>  MODULE_AUTHOR(DRIVER_AUTHOR);