linux-kernel - Re: [PATCH v2 01/10] sched: Add support to pick functions to take rf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD88h1kvJguRN0mC@slm.duckdns.org>
Date: Tue, 3 Jun 2025 08:18:47 -1000
From: Tejun Heo <tj@...nel.org>
To: Joel Fernandes <joelagnelf@...dia.com>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	David Vernet <void@...ifault.com>, Andrea Righi <arighi@...dia.com>,
	Changwoo Min <changwoo@...lia.com>
Subject: Re: [PATCH v2 01/10] sched: Add support to pick functions to take rf

On Tue, Jun 03, 2025 at 09:38:35AM -0400, Joel Fernandes wrote:
> On 6/2/2025 8:05 PM, Tejun Heo wrote:
> > Hello,
> > 
> > On Mon, Jun 02, 2025 at 02:00:57PM -0400, Joel Fernandes wrote:
> >> Some pick functions like the internal pick_next_task_fair() already take
> >> rf but some others dont. We need this for scx's server pick function.
> >> Prepare for this by having pick functions accept it.
> > 
> > Hmm.. after the whole patch series is applied, pick_task_scx() still doesn't
> > seem to use @rf. What am I missing?
> I need it for scx *server*'s pick_task, i.e. ext_server_pick_task().
> 
> Sure we're not using it in pick_task_scx(), but I added it there for consistency
> since pick_task_dl() needs it, due to ext_server_pick_task() needing it.

Ah, yeah, I just missed the usage on the server side. Thanks for the
explanation.

-- 
tejun