linux-kernel - Re: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <273da934-deeb-4129-917c-5d7038930941@kernel.org>
Date: Tue, 3 Jun 2025 11:22:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jammy Huang <jammy_huang@...eedtech.com>, jassisinghbrar@...il.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, joel@....id.au,
 andrew@...econstruct.com.au, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series
 SoC

On 03/06/2025 09:54, Jammy Huang wrote:
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#mbox-cells":
> +    const: 1
> +    description: |
> +      <&phandle channel>
> +      phandle : Label name of mailbox controller
> +      channel : 0-3, Channel index

Drop description, pretty obvious (or just say that second argument is
channel number).

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    mbox@...1c200 {

mailbox@

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof