linux-kernel - Re: [PATCH v10 01/11] dt-bindings: mfd: gpio: Add MAX7360

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bce7f87-7599-404c-abd4-894078c20665@kernel.org>
Date: Tue, 3 Jun 2025 11:27:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kamel Bouhara <kamel.bouhara@...tlin.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Uwe Kleine-König <ukleinek@...nel.org>,
 Michael Walle <mwalle@...nel.org>, Mark Brown <broonie@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-input@...r.kernel.org,
 linux-pwm@...r.kernel.org, andriy.shevchenko@...el.com,
 Grégory Clement <gregory.clement@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v10 01/11] dt-bindings: mfd: gpio: Add MAX7360

On 03/06/2025 10:14, Mathieu Dubois-Briand wrote:
> On Mon Jun 2, 2025 at 1:21 PM CEST, Krzysztof Kozlowski wrote:
>> On 30/05/2025 12:00, Mathieu Dubois-Briand wrote:
>>> Add device tree bindings for Maxim Integrated MAX7360 device with
>>> support for keypad, rotary, gpios and pwm functionalities.
>>>
>>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
>>> ---
>>>  .../bindings/gpio/maxim,max7360-gpio.yaml          |  83 +++++++++
>>>  .../devicetree/bindings/mfd/maxim,max7360.yaml     | 191 +++++++++++++++++++++
>>>  2 files changed, 274 insertions(+)
>>>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>> of patchset, under or above your Signed-off-by tag, unless patch changed
>> significantly (e.g. new properties added to the DT bindings). Tag is
>> "received", when provided in a message replied to you on the mailing
>> list. Tools like b4 can help here. However, there's no need to repost
>> patches *only* to add the tags. The upstream maintainer will do that for
>> tags received on the version they apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>>
> 
> I previously decided to drop your Reviewed-by tag as I made some

And this should be explained in cover letter. Read above form letter
again. Read also link to submitting patches.

> substantial changes since you gave it. Main difference since v4 of this
> series is add of the pinctrl bindings and some additional
> "rotary-encoder,*" properties.

Sure, that's fine. Lack of explanation is what I question here.

Best regards,
Krzysztof