linux-kernel - Re: [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c40fd836-ac63-48d0-93aa-8dd5f3dbcf79@cjdns.fr>
Date: Tue, 3 Jun 2025 12:05:17 +0200
From: Caleb James DeLisle <cjd@...ns.fr>
To: Chen Ni <nichen@...as.ac.cn>, daniel.lezcano@...aro.org,
 tglx@...utronix.de
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/timer-econet-en751221: Convert comma to
 semicolon


On 03/06/2025 08:04, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Tested-by: Caleb James DeLisle <cjd@...ns.fr>


The comma was indeed unintended, thank you.

Caleb

> ---
>   drivers/clocksource/timer-econet-en751221.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-econet-en751221.c b/drivers/clocksource/timer-econet-en751221.c
> index 3b449fdaafee..4008076b1a21 100644
> --- a/drivers/clocksource/timer-econet-en751221.c
> +++ b/drivers/clocksource/timer-econet-en751221.c
> @@ -146,7 +146,7 @@ static int __init cevt_init(struct device_node *np)
>   	for_each_possible_cpu(i) {
>   		struct clock_event_device *cd = &per_cpu(econet_timer_pcpu, i);
>   
> -		cd->rating		= 310,
> +		cd->rating		= 310;
>   		cd->features		= CLOCK_EVT_FEAT_ONESHOT |
>   					  CLOCK_EVT_FEAT_C3STOP |
>   					  CLOCK_EVT_FEAT_PERCPU;